WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161331
Get rid of another use of WebProcessProxy::fromConnection
https://bugs.webkit.org/show_bug.cgi?id=161331
Summary
Get rid of another use of WebProcessProxy::fromConnection
Anders Carlsson
Reported
2016-08-29 13:54:32 PDT
Get rid of another use of WebProcessProxy::fromConnection
Attachments
Patch
(23.54 KB, patch)
2016-08-29 14:04 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2016-08-29 14:04:49 PDT
Created
attachment 287319
[details]
Patch
mitz
Comment 2
2016-08-29 14:44:40 PDT
Comment on
attachment 287319
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=287319&action=review
> Source/WebKit2/ChangeLog:10 > + and fill it in on the web process side and send it over to tehe UI process where an API::FrameInfo object can be created.
Typo: “tehe”.
> Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:103 > + virtual void didPostMessage(WebKit::WebPageProxy& page, const WebKit::FrameInfoData& frameInfoData, WebCore::SerializedScriptValue& serializedScriptValue) override
Get rid of “virtual”.
Anders Carlsson
Comment 3
2016-08-29 15:02:43 PDT
Committed
r205150
: <
http://trac.webkit.org/changeset/205150
>
Gyuyoung Kim
Comment 4
2016-08-29 18:59:11 PDT
(In reply to
comment #3
)
> Committed
r205150
: <
http://trac.webkit.org/changeset/205150
>
Fix build break on EFL/GTK -
https://trac.webkit.org/changeset/205167
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug