Bug 161328 - fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
Summary: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2016-08-29 13:44 PDT by Alexey Proskuryakov
Modified: 2017-01-03 17:52 PST (History)
8 users (show)

See Also:


Attachments
Patch (10.97 KB, patch)
2016-12-22 01:06 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2016-12-22 01:18 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-08-29 13:44:13 PDT
fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html fails most of the time for me when run like this:

run-webkit-tests --ios-simulator --no-retry fast/events/ios/viewport-device-width-at-initial-scale-fast-clicks.html fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html -v
Comment 1 Radar WebKit Bug Importer 2016-09-26 10:00:32 PDT
<rdar://problem/28475977>
Comment 2 Wenson Hsieh 2016-12-22 01:06:34 PST
Created attachment 297649 [details]
Patch
Comment 3 Wenson Hsieh 2016-12-22 01:18:54 PST
Created attachment 297650 [details]
Patch
Comment 4 Alexey Proskuryakov 2016-12-22 09:09:02 PST
Comment on attachment 297650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297650&action=review

> Tools/ChangeLog:19
> +        One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,

Is this comment obsolete now?
Comment 5 Wenson Hsieh 2016-12-22 09:12:50 PST
Comment on attachment 297650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=297650&action=review

>> Tools/ChangeLog:19
>> +        One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
> 
> Is this comment obsolete now?

This comment is still relevant. Unless all animations are removed from the WKScrollView and its children, UIKit will defer firing the end zooming callback until later (possibly in the next test).
Comment 6 WebKit Commit Bot 2016-12-22 09:38:34 PST
Comment on attachment 297650 [details]
Patch

Clearing flags on attachment: 297650

Committed r210101: <http://trac.webkit.org/changeset/210101>
Comment 7 WebKit Commit Bot 2016-12-22 09:38:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2017-01-03 17:52:50 PST
Confirmed that this fixed it for me. Thanks!