RESOLVED FIXED 161322
Stop using WebProcessProxy::fromConnection in WebPageProxy 
https://bugs.webkit.org/show_bug.cgi?id=161322
Summary Stop using WebProcessProxy::fromConnection in WebPageProxy
Anders Carlsson
Reported 2016-08-29 12:39:49 PDT
Stop using WebProcessProxy::fromConnection in WebPageProxy
Attachments
Patch (2.96 KB, patch)
2016-08-29 12:40 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-08-29 12:40:23 PDT
Created attachment 287308 [details] Patch
Darin Adler
Comment 2 2016-08-29 12:42:45 PDT
Comment on attachment 287308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287308&action=review > Source/WebKit2/ChangeLog:8 > + The WebPageProxy alreayd knows its WebProcessProxy - no need to look it up from the connection. Typo: already misspelled. > Source/WebKit2/UIProcess/WebPageProxy.cpp:672 > + ASSERT(m_process->connection() == &connection); Is there a solid guarantee that m_process is not null in these functions?
Anders Carlsson
Comment 3 2016-08-29 12:46:26 PDT
(In reply to comment #2) > Comment on attachment 287308 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=287308&action=review > > > Source/WebKit2/ChangeLog:8 > > + The WebPageProxy alreayd knows its WebProcessProxy - no need to look it up from the connection. > > Typo: already misspelled. > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:672 > > + ASSERT(m_process->connection() == &connection); > > Is there a solid guarantee that m_process is not null in these functions? m_process is never null. m_process->connection() can be null during launch, but no incoming messages are dispatched at that time.
Anders Carlsson
Comment 4 2016-08-29 12:46:50 PDT
Committed r205137: <http://trac.webkit.org/changeset/205137>
Note You need to log in before you can comment on or make changes to this bug.