RESOLVED WONTFIX 161306
Move direction property into the operator dictionary
https://bugs.webkit.org/show_bug.cgi?id=161306
Summary Move direction property into the operator dictionary
Frédéric Wang (:fredw)
Reported 2016-08-28 23:10:00 PDT
Currently MathMLOperatorDictionary has one dictionary indexed by Operator+Form and a list of horizontal operators. We could do like in Gecko and make "horizontal" a boolean property (encoded by a new MathMLOperatorDictionary::Flag), so that it can be directly integrated into the operator dictionary and accessed via MathMLOperatorDictionary::search. We just need to ensure that all the forms have the same direction.
Attachments
Experimental Patch (31.60 KB, patch)
2016-08-30 03:13 PDT, Frédéric Wang (:fredw)
no flags
Frédéric Wang (:fredw)
Comment 1 2016-08-28 23:10:55 PDT
(In reply to comment #0) > We just need to ensure that all the forms have the same direction. ... and we call MathMLOperatorDictionary::search with explicitForm = false
Frédéric Wang (:fredw)
Comment 2 2016-08-30 03:13:47 PDT
Created attachment 287383 [details] Experimental Patch
Javier Fernandez
Comment 3 2016-09-12 05:32:56 PDT
Comment on attachment 287383 [details] Experimental Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287383&action=review > Source/WebCore/mathml/MathMLOperatorElement.cpp:128 > + break; Why we don't return an attribute name for the case of Horizontal ?
Frédéric Wang (:fredw)
Comment 4 2016-09-12 05:35:37 PDT
Comment on attachment 287383 [details] Experimental Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287383&action=review >> Source/WebCore/mathml/MathMLOperatorElement.cpp:128 >> + break; > > Why we don't return an attribute name for the case of Horizontal ? Because horizontal is not a MathML attribute. It's just a property that we assign internally to a Unicode character.
Frédéric Wang (:fredw)
Comment 5 2024-10-10 02:38:48 PDT
Note You need to log in before you can comment on or make changes to this bug.