RESOLVED FIXED 161304
Web Inspector: Value checks of secondsPerPixel cause errors 
https://bugs.webkit.org/show_bug.cgi?id=161304
Summary Web Inspector: Value checks of secondsPerPixel cause errors
Devin Rousso
Reported 2016-08-28 17:14:56 PDT
WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TimelineRecordBar.js:232:23: CONSOLE ERROR WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TimelineDataGridNode.js:230:23: CONSOLE ERROR Both lines are along the lines of: console.assert(graphDataSource.secondsPerPixel); I'm guessing that this may be due to the fact that secondsPerPixel is initially 0, which will trigger assertions.
Attachments
[Patch] Proposed Fix (2.72 KB, patch)
2016-08-29 20:58 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] Proposed Fix (4.09 KB, patch)
2016-09-01 14:09 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-28 17:15:09 PDT
<rdar://problem/28050070>
Matt Baker
Comment 2 2016-08-29 20:52:22 PDT
These are mostly the fault of NetworkTimelineView, which wasn't clearing all its cached data on recording reset, and in addition didn't check that time stamps were actually changing before doing a layout. The latter resulted in trying to refresh graphs when endTime - startTime === 0, resulting in an invalid value for secondsPerPixel.
Matt Baker
Comment 3 2016-08-29 20:58:06 PDT
Created attachment 287368 [details] [Patch] Proposed Fix
Blaze Burg
Comment 4 2016-09-01 11:29:27 PDT
Comment on attachment 287368 [details] [Patch] Proposed Fix This patch is missing a changelog. Ideally it would explain the sequence of events to cause this assertion and why the sequence is now different.
Matt Baker
Comment 5 2016-09-01 14:09:45 PDT
Created attachment 287675 [details] [Patch] Proposed Fix
Blaze Burg
Comment 6 2016-09-01 14:11:25 PDT
Comment on attachment 287675 [details] [Patch] Proposed Fix r=me, very thank you for changelog ;-)
Matt Baker
Comment 7 2016-09-01 14:17:08 PDT
(In reply to comment #6) > Comment on attachment 287675 [details] > [Patch] Proposed Fix > > r=me, very thank you for changelog ;-) It was already written, just got left behind :)
WebKit Commit Bot
Comment 8 2016-09-01 15:06:55 PDT
Comment on attachment 287675 [details] [Patch] Proposed Fix Clearing flags on attachment: 287675 Committed r205320: <http://trac.webkit.org/changeset/205320>
WebKit Commit Bot
Comment 9 2016-09-01 15:07:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.