Bug 161296 - [iOS] Build fails in JSCLLIntOffsetsExtractor - Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'
Summary: [iOS] Build fails in JSCLLIntOffsetsExtractor - Ad Hoc code signing is not al...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad Other
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-27 20:27 PDT by Benjamin King
Modified: 2016-09-06 17:31 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2016-09-06 17:10 PDT, Daniel Bates 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin King 2016-08-27 20:27:00 PDT 
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@205094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.12
BuildVersion:	16A304a
$ xcode-select -p
/Applications/Xcode-beta.app/Contents/Developer
$ xcodebuild -version
Xcode 8.0
Build version 8S201h
# Xcode 8 beta 6 - Aug 15, 2016

Steps to reproduce:

1. Build WebKit: Tools/Scripts/build-webkit --ios-simulator

Expected Result: 

Should build WebKit for the iOS Simulator

Actual Result:

Build fails:

=== BUILD TARGET JSCLLIntOffsetsExtractor OF PROJECT JavaScriptCore WITH CONFIGURATION Release ===

Check dependencies
Base.xcconfig line 23: Unable to find included file "../../../../Internal/Configurations/HaveInternalSDK.xcconfig"
Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'

** BUILD FAILED **


The following build commands failed:
	Check dependencies
(1 failure)
Comment 1 Daniel Bates 2016-09-06 17:10:19 PDT 
Created attachment 288070 [details]
Patch
Comment 2 mitz 2016-09-06 17:12:11 PDT 
Comment on attachment 288070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288070&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:97
> +AD_HOC_CODE_SIGNING_ALLOWED[sdk=iphonesimulator*] = YES;

Is the sdk qualifier necessary here? If it works without it, I think we should not specify it.
Comment 3 Daniel Bates 2016-09-06 17:20:29 PDT 
(In reply to comment #2)
> Comment on attachment 288070 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288070&action=review
> 
> > Source/JavaScriptCore/Configurations/Base.xcconfig:97
> > +AD_HOC_CODE_SIGNING_ALLOWED[sdk=iphonesimulator*] = YES;
> 
> Is the sdk qualifier necessary here? If it works without it, I think we
> should not specify it.

Will remove the SDK qualifier before landing as it is not necessary.
Comment 4 Daniel Bates 2016-09-06 17:31:22 PDT 
Committed r205528: <http://trac.webkit.org/changeset/205528>