Bug 161292 – Clean up some .text attribute setters that don't throw.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andreas Kling]

These elements have a .text setter with [SetterRaisesExceptions] that will never actually throw:

HTMLAnchorElement
HTMLOptionElement
HTMLTitleElement

[Andreas Kling]

Created attachment 287208 [details]
Patch

[Andreas Kling]

Comment on attachment 287208 [details]
Patch

Looks like this needs to undo https://trac.webkit.org/changeset/203158 if/when landed.

[Darin Adler]

Comment on attachment 287208 [details]
Patch

Assuming you fix the gobject bindings, looks good!

[Chris Dumez]

Comment on attachment 287208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287208&action=review

> Source/WebCore/html/HTMLOptionElement.cpp:113
> +void HTMLOptionElement::setText(const String &text)

& on wrong side

[Radar WebKit Bug Importer]

<rdar://problem/28046467>

[Andreas Kling]

Created attachment 287233 [details]
Patch for landing

Attempt to fix GObject bindings.

[WebKit Commit Bot]

Comment on attachment 287233 [details]
Patch for landing

Rejecting attachment 287233 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 287233, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/mac/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1960257

[Andreas Kling]

Created attachment 287234 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 287234 [details]
Patch for landing

Clearing flags on attachment: 287234

Committed r205104: <http://trac.webkit.org/changeset/205104>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.