Bug 161288 – Hook up UIScriptController::typeCharacterUsingHardwareKeyboard in WebKitTestRunner on Mac

• Status: NEW
• Component: New Bugs

[Simon Fraser (smfr)]

Hook up UIScriptController::typeCharacterUsingHardwareKeyboard in WebKitTestRunner on Mac

[Simon Fraser (smfr)]

Created attachment 287198 [details]
Patch

[WebKit Commit Bot]

Attachment 287198 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:293:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:316:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:63:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 287206 [details]
Patch

[WebKit Commit Bot]

Attachment 287206 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:293:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:316:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:63:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 3 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Not sure what to do for 32-bit WTR. Do I need to make testing work there, and thus bypass using the API?

[Wenson Hsieh]

Comment on attachment 287206 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287206&action=review

> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:63
> +    webView.didCompleteKeyEventHandlingCallback = ^void(NSEvent *event, BOOL handled) {

Nit - we can remove the void here.

> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:64
> +        if (!protectedThis->context())

Nit - maybe put protectedThis->context() into a local?

> LayoutTests/fast/events/keypress-via-uiscriptcontroller.html:15
> +                });

Just to make sure -- are these completion callbacks guaranteed to be invoked in the same order uiController.typeCharacterUsingHardwareKeyboard was called? If not, we might need a mechanism that increments/decrements the count of in-flight events and then calls uiScriptComplete when the count hits 0.

IIRC, we ran into some crashes on iOS due to a similar scenario that caused some callbacks to be fired after the test completed. It looks like we now have guards against that though.

[Build Bot]

Comment on attachment 287206 [details]
Patch

Attachment 287206 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1954841

New failing tests:
fast/scrolling/ios/scrollTo-at-page-load.html
fast/events/keypress-via-uiscriptcontroller.html

[Build Bot]

Created attachment 287207 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Brady Eidson]

Comment on attachment 287206 [details]
Patch

Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form.

If this patch is still important please rebase it and post it for review again.