WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
161288
Hook up UIScriptController::typeCharacterUsingHardwareKeyboard in WebKitTestRunner on Mac
https://bugs.webkit.org/show_bug.cgi?id=161288
Summary
Hook up UIScriptController::typeCharacterUsingHardwareKeyboard in WebKitTestR...
Simon Fraser (smfr)
Reported
2016-08-26 23:02:35 PDT
Hook up UIScriptController::typeCharacterUsingHardwareKeyboard in WebKitTestRunner on Mac
Attachments
Patch
(56.70 KB, patch)
2016-08-26 23:15 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(56.29 KB, patch)
2016-08-27 10:28 PDT
,
Simon Fraser (smfr)
beidson
: review-
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2
(669.21 KB, application/zip)
2016-08-27 11:40 PDT
,
Build Bot
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2016-08-26 23:15:02 PDT
Created
attachment 287198
[details]
Patch
WebKit Commit Bot
Comment 2
2016-08-26 23:18:37 PDT
Attachment 287198
[details]
did not pass style-queue: ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:63: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3
2016-08-27 10:28:47 PDT
Created
attachment 287206
[details]
Patch
WebKit Commit Bot
Comment 4
2016-08-27 10:31:14 PDT
Attachment 287206
[details]
did not pass style-queue: ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:293: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebKitTestRunner/mac/EventSenderProxy.mm:316: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:63: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 3 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 5
2016-08-27 11:14:42 PDT
Not sure what to do for 32-bit WTR. Do I need to make testing work there, and thus bypass using the API?
Wenson Hsieh
Comment 6
2016-08-27 11:25:10 PDT
Comment on
attachment 287206
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=287206&action=review
> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:63 > + webView.didCompleteKeyEventHandlingCallback = ^void(NSEvent *event, BOOL handled) {
Nit - we can remove the void here.
> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:64 > + if (!protectedThis->context())
Nit - maybe put protectedThis->context() into a local?
> LayoutTests/fast/events/keypress-via-uiscriptcontroller.html:15 > + });
Just to make sure -- are these completion callbacks guaranteed to be invoked in the same order uiController.typeCharacterUsingHardwareKeyboard was called? If not, we might need a mechanism that increments/decrements the count of in-flight events and then calls uiScriptComplete when the count hits 0. IIRC, we ran into some crashes on iOS due to a similar scenario that caused some callbacks to be fired after the test completed. It looks like we now have guards against that though.
Build Bot
Comment 7
2016-08-27 11:40:52 PDT
Comment on
attachment 287206
[details]
Patch
Attachment 287206
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/1954841
New failing tests: fast/scrolling/ios/scrollTo-at-page-load.html fast/events/keypress-via-uiscriptcontroller.html
Build Bot
Comment 8
2016-08-27 11:40:56 PDT
Created
attachment 287207
[details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Brady Eidson
Comment 9
2018-02-14 10:33:55 PST
Comment on
attachment 287206
[details]
Patch Patches that have been up for review since 2016 are almost certainly too stale to be relevant to trunk in their current form. If this patch is still important please rebase it and post it for review again.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug