Bug 161282 - URLParser should parse relative URLs
Summary: URLParser should parse relative URLs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-26 18:45 PDT by Alex Christensen
Modified: 2016-08-29 11:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.20 KB, patch)
2016-08-26 19:15 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (24.18 KB, patch)
2016-08-26 20:10 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (1023.39 KB, application/zip)
2016-08-26 21:13 PDT, Build Bot 		no flags Details
Patch (24.60 KB, patch)
2016-08-27 13:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-26 18:45:01 PDT 
URLParser should parse relative URLs
Comment 1 Alex Christensen 2016-08-26 19:15:38 PDT 
Created attachment 287188 [details]
Patch
Comment 2 Alex Christensen 2016-08-26 20:08:22 PDT 
Comment on attachment 287188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287188&action=review

> Source/WebCore/platform/URLParser.cpp:88
> +}

I'll ASSERT_NOT_REACHED() and return 0 here when committing.
Comment 3 Alex Christensen 2016-08-26 20:10:27 PDT 
Created attachment 287193 [details]
Patch
Comment 4 Build Bot 2016-08-26 21:13:09 PDT 
Comment on attachment 287193 [details]
Patch

Attachment 287193 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1951330

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-08-26 21:13:22 PDT 
Created attachment 287195 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Alex Christensen 2016-08-26 23:51:13 PDT 
Comment on attachment 287193 [details]
Patch

I need to change the assertion in StringView::CodePoints::Iterator::operator== from ASSERT(&m_stringView == &other.m_stringView); to ASSERT(&m_stringView.get() == &other.m_stringView.get());
Pretend I did that and that there are no more assertion failures when reviewing.
Comment 7 Alex Christensen 2016-08-27 13:54:53 PDT 
Created attachment 287212 [details]
Patch
Comment 8 WebKit Commit Bot 2016-08-27 22:57:06 PDT 
Comment on attachment 287212 [details]
Patch

Clearing flags on attachment: 287212

Committed r205097: <http://trac.webkit.org/changeset/205097>
Comment 9 WebKit Commit Bot 2016-08-27 22:57:12 PDT 
All reviewed patches have been landed.  Closing bug.