Bug 161281 - setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() should be guarded by "#if PLATFORM(WIN)" in ResourceHandleCurl.cpp
Summary: setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() should be g...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Curl
Depends on:
Blocks:
 
Reported: 2016-08-26 17:53 PDT by Yoshiaki Jitsukawa
Modified: 2016-08-27 14:36 PDT (History)
2 users (show)

See Also:

Attachments
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() (1.36 KB, patch)
2016-08-26 18:12 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2016-08-26 17:53:04 PDT 
ResourceHandle::setHostAllowsAnyHTTPSCertificate() and ResourceHandle::setClientCertificateInfo() are declared only #if PLATFORM(WIN) && USE(CURL), but the implementation in ResourceHandleCurl.cpp is not guarded, which may cause compilation errors on the other platforms with curl support.
Comment 1 Yoshiaki Jitsukawa 2016-08-26 18:12:48 PDT 
Created attachment 287184 [details]
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo()
Comment 2 WebKit Commit Bot 2016-08-27 14:36:46 PDT 
Comment on attachment 287184 [details]
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo()

Clearing flags on attachment: 287184

Committed r205084: <http://trac.webkit.org/changeset/205084>
Comment 3 WebKit Commit Bot 2016-08-27 14:36:49 PDT 
All reviewed patches have been landed.  Closing bug.