Bug 161265 – Add a test harness for running UI tests on the iOS Simulator

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Add a test harness for running UI tests on the iOS Simulator

[Radar WebKit Bug Importer]

<rdar://problem/28036120>

[Jer Noble]

Created attachment 287144 [details]
Patch

[WebKit Commit Bot]

Attachment 287144 [details] did not pass style-queue:


ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m:59:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m:71:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m:83:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m:102:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:32:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:88:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:77:  Extra space after ( in if  [whitespace/parens] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:77:  Extra space before ) in if  [whitespace/parens] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:87:  Extra space before ) in if  [whitespace/parens] [5]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/main.m:27:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/main.m:29:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 15 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jer Noble]

Created attachment 287145 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 287145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287145&action=review

> Tools/ChangeLog:76
> +        Remove deprecated ENCRYPTED_MEDIA implementation.
> +        https://bugs.webkit.org/show_bug.cgi?id=161010
> +
> +        Reviewed by Eric Carlson.
> +
> +        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Is this bit relevant?

> Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m:66
> +- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
> +    // Override point for customization after application launch.
> +    return YES;
> +}
> +
> +
> +- (void)applicationWillResignActive:(UIApplication *)application {
> +    // Sent when the application is about to move from active to inactive state. This can occur for certain types of temporary interruptions (such as an incoming phone call or SMS message) or when the user quits the application and it begins the transition to the background state.
> +    // Use this method to pause ongoing tasks, disable timers, and invalidate graphics rendering callbacks. Games should use this method to pause the game.
> +}
> +
> +
> +- (void)applicationDidEnterBackground:(UIApplication *)application {
> +    // Use this method to release shared resources, save user data, invalidate timers, and store enough application state information to restore your application to its current state in case it is terminated later.
> +    // If your application supports background execution, this method is called instead of applicationWillTerminate: when the user quits.
> +}
> +
> +
> +- (void)applicationWillEnterForeground:(UIApplication *)application {
> +    // Called as part of the transition from the background to the active state; here you can undo many of the changes made on entering the background.
> +}
> +
> +
> +- (void)applicationDidBecomeActive:(UIApplication *)application {
> +    // Restart any tasks that were paused (or not yet started) while the application was inactive. If the application was previously in the background, optionally refresh the user interface.
> +}
> +
> +
> +- (void)applicationWillTerminate:(UIApplication *)application {
> +    // Called when the application is about to terminate. Save data if appropriate. See also applicationDidEnterBackground:.
> +}

Remove the ones you're not using. Braces on new line.

> Tools/MobileMiniBrowser/MobileMiniBrowser/Info.plist:4
> +<?xml version="1.0" encoding="UTF-8"?>
> +<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
> +<plist version="1.0">
> +<dict>

Don't you need TARGETED_DEVICE_FAMILY = 1,2 stuff in here to run on iPhone and iPad?

> Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h:39
> +@property (strong, nonatomic) IBOutlet WKWebView *webView;
> +@property (strong, nonatomic) IBOutlet UITextField *urlField;
> +@property (strong, nonatomic) IBOutlet UIProgressView *progressView;
> +@property (strong, nonatomic) IBOutlet UIBarButtonItem *tabButton;
> +@property (strong, nonatomic) IBOutlet TabViewController *tabViewController;
> +@property (strong, nonatomic) NSMutableArray<WKWebView *> *webViews;

Why both webView and webViews? Maybe webView should be currentWebView

> Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:47
> +- (void)viewDidLoad {

Brace on new line.

> Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:58
> +- (void)didReceiveMemoryWarning {

Brace.

[Jer Noble]

Comment on attachment 287145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287145&action=review

>> Tools/ChangeLog:76
>> +        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
> 
> Is this bit relevant?

Whoops. nope.

>> Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m:66
>> +}
> 
> Remove the ones you're not using. Braces on new line.

Weird that the style bot didn't catch these (autogenerated) methods.  Will fix.

>> Tools/MobileMiniBrowser/MobileMiniBrowser/Info.plist:4
>> +<dict>
> 
> Don't you need TARGETED_DEVICE_FAMILY = 1,2 stuff in here to run on iPhone and iPad?

That's in the Base.xcconfig. (::looks::) So sayeth the documentation:

"Important: Do not insert this key manually into your Info.plist files. Xcode inserts it automatically based on the value in the Targeted Device Family build setting. You should use that build setting to change the value of the key."

>> Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h:39
>> +@property (strong, nonatomic) NSMutableArray<WKWebView *> *webViews;
> 
> Why both webView and webViews? Maybe webView should be currentWebView

Yeah, webView could really be currentWebView.

>> Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:47
>> +- (void)viewDidLoad {
> 
> Brace on new line.

Will fix.

>> Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m:58
>> +- (void)didReceiveMemoryWarning {
> 
> Brace.

Will fix.

[Jer Noble]

Created attachment 287158 [details]
Patch for landing

[Jer Noble]

Committed r205057: <http://trac.webkit.org/changeset/205057>