Bug 161263 – REGRESSION(r202568): Web Inspector: Expanding Array Prototype in Console shows no properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
REGRESSION: Web Inspector: Expanding Array Prototype in Console shows no properties

Steps to reproduce:
1. js> dir([])
2. Expand Array Prototype
  => Says "No Properties" expected all the Array methods (sort, reduce, forEach, ...)

Notes:
- I think this is because [].__proto__ is an array instance with 0 length. We dropped the length requirement in <https://trac.webkit.org/r202568>

[Radar WebKit Bug Importer]

<rdar://problem/28035849>

[Joseph Pecoraro]

Created attachment 287151 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 287152 [details]
[IMAGE] Before

[Joseph Pecoraro]

Created attachment 287153 [details]
[IMAGE] After

[Matt Baker]

Comment on attachment 287151 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=287151&action=review

r=me

> LayoutTests/inspector/model/remote-object-get-properties.html:60
> +        {expression: "window.arrayProto"},

Isn't the arrayProto step covered by simpleArray?

[Joseph Pecoraro]

(In reply to comment #5)
> Comment on attachment 287151 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287151&action=review
> 
> r=me
> 
> > LayoutTests/inspector/model/remote-object-get-properties.html:60
> > +        {expression: "window.arrayProto"},
> 
> Isn't the arrayProto step covered by simpleArray?

Nope, but we didn't have a test for an Array so I added one.

[WebKit Commit Bot]

Comment on attachment 287151 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 287151

Committed r205168: <http://trac.webkit.org/changeset/205168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.