Bug 161246 - Typo fix after r56209
Summary: Typo fix after r56209
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 35308
  Show dependency tree / graph
 
Reported: 2016-08-26 08:41 PDT by Csaba Osztrogonác
Modified: 2016-08-26 09:34 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2016-08-26 08:43 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-08-26 08:41:52 PDT 
http://trac.webkit.org/changeset/56209 caused build failure with GCC 6 ( 6.5 years later :)) )

../../Source/WebCore/page/FrameView.cpp: In member function ‘void WebCore::FrameView::adjustMediaTypeForPrinting(bool)’:
../../Source/WebCore/page/FrameView.cpp:1606:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
         if (m_mediaTypeWhenNotPrinting.isNull())
         ^~
../../Source/WebCore/page/FrameView.cpp:1608:13: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
             setMediaType("print");
             ^~~~~~~~~~~~

"setMediaType("print");" line was indented misleadingly, it should be fixed.
Darin's comment was good in https://bugs.webkit.org/show_bug.cgi?id=35308#c16,
but the landed patch was wrong.

Let's make GCC happy. ;)
Comment 1 Csaba Osztrogonác 2016-08-26 08:43:40 PDT 
Created attachment 287106 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-26 09:34:53 PDT 
Comment on attachment 287106 [details]
Patch

Clearing flags on attachment: 287106

Committed r205015: <http://trac.webkit.org/changeset/205015>
Comment 3 WebKit Commit Bot 2016-08-26 09:34:57 PDT 
All reviewed patches have been landed.  Closing bug.