RESOLVED FIXED161243
[Win] Enable 'warning as error' compiler setting. 
https://bugs.webkit.org/show_bug.cgi?id=161243
Summary [Win] Enable 'warning as error' compiler setting.
Per Arne Vollan
Reported 2016-08-26 07:56:05 PDT
This setting should be enabled on Windows as well.
Attachments
Patch (2.02 KB, patch)
2016-08-26 08:07 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (2.02 KB, patch)
2016-08-26 11:05 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2016-08-26 08:07:25 PDT
Created attachment 287105 [details] Patch
Brent Fulgham
Comment 2 2016-08-26 08:49:36 PDT
Comment on attachment 287105 [details] Patch I'm so excited to see this getting close! Are our build bots warning-less at this point? I don't think we should land this until the build bots do not have any warnings.
Per Arne Vollan
Comment 3 2016-08-26 10:19:25 PDT
(In reply to comment #2) > Comment on attachment 287105 [details] > Patch > > I'm so excited to see this getting close! Are our build bots warning-less at > this point? I don't think we should land this until the build bots do not > have any warnings. Me too :) I think I'll upload this patch once more after the other patches are landed (to check that it builds). Thanks for reviewing!
Per Arne Vollan
Comment 4 2016-08-26 11:05:47 PDT
Created attachment 287123 [details] Patch
Per Arne Vollan
Comment 5 2016-08-26 12:03:48 PDT
Comment on attachment 287123 [details] Patch The patch also builds with VS2015 Update 3.
Alex Christensen
Comment 6 2016-08-26 13:14:10 PDT
Comment on attachment 287123 [details] Patch This adds /wd4206 (nonstandard extension used : translation unit is empty) and /wd4722 ('function': destructor never returns, potential memory leak). Why do we need to add 4722?
WebKit Commit Bot
Comment 7 2016-08-27 17:16:10 PDT
Comment on attachment 287123 [details] Patch Clearing flags on attachment: 287123 Committed r205090: <http://trac.webkit.org/changeset/205090>
WebKit Commit Bot
Comment 8 2016-08-27 17:16:19 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 9 2016-08-28 10:32:41 PDT
(In reply to comment #7) > Comment on attachment 287123 [details] > Patch > > Clearing flags on attachment: 287123 > > Committed r205090: <http://trac.webkit.org/changeset/205090> It broke the ApplecWindows and WinCairo build, see build.webkit.org for details.
Per Arne Vollan
Comment 10 2016-08-29 05:42:31 PDT
(In reply to comment #6) > Comment on attachment 287123 [details] > Patch > > This adds /wd4206 (nonstandard extension used : translation unit is empty) > and /wd4722 ('function': destructor never returns, potential memory leak). > Why do we need to add 4722? This was added because of the following code: JITWorklist::~JITWorklist() { UNREACHABLE_FOR_PLATFORM(); }
Note You need to log in before you can comment on or make changes to this bug.