Bug 161234 – [css-grid] Do not recursively call layout during auto repeat computation

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sergio Villar Senin]

[css-grid] Do not recursively call layout during auto repeat computation

[Sergio Villar Senin]

Created attachment 287095 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 287095 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287095&action=review

r=me granted you fix the build before landing :-)

> Source/WebCore/ChangeLog:15
> +        This fix also unveiled a few errors in one of the imported mozilla tests which were
> +        incorrectly passing when they should not.

Have we reported these errors back to Mozilla?

> Source/WebCore/rendering/RenderGrid.cpp:1526
> +    ASSERT(m_gridItemsIndexesMap.isEmpty());

This seems wrong, we don't have that in WebKit. Maybe you want to check that m_grid.isEmty() too.

> LayoutTests/ChangeLog:13
> +        * fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001-expected.html:

Mozilla tests are too complex, could you elaborate a little bit here what was wrong?

[Build Bot]

Comment on attachment 287095 [details]
Patch

Attachment 287095 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1946197

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 287097 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Sergio Villar Senin]

(In reply to comment #2)
> Comment on attachment 287095 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287095&action=review
> 
> r=me granted you fix the build before landing :-)
> 
> > Source/WebCore/ChangeLog:15
> > +        This fix also unveiled a few errors in one of the imported mozilla tests which were
> > +        incorrectly passing when they should not.
> 
> Have we reported these errors back to Mozilla?

Yes https://bugzilla.mozilla.org/show_bug.cgi?id=1280798

> 
> > Source/WebCore/rendering/RenderGrid.cpp:1526
> > +    ASSERT(m_gridItemsIndexesMap.isEmpty());
> 
> This seems wrong, we don't have that in WebKit. Maybe you want to check that
> m_grid.isEmty() too.

Ups

> 
> > LayoutTests/ChangeLog:13
> > +        * fast/css-grid-layout/mozilla/grid-repeat-auto-fill-fit-001-expected.html:
> 
> Mozilla tests are too complex, could you elaborate a little bit here what
> was wrong?

OK

[Sergio Villar Senin]

Committed r205114: <http://trac.webkit.org/changeset/205114>