Bug 161229 – [JSC] Implement CompareStrictEq(String, Untyped) in FTL

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[JSC] Implement CompareStrictEq(String, Untyped) in FTL

[Benjamin Poulain]

Created attachment 287077 [details]
Patch

[Geoffrey Garen]

Comment on attachment 287077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287077&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5204
> +        // Given left is string. If the value are strictly equal, rightValue has to be the same string.

values

[Saam Barati]

Comment on attachment 287077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287077&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5179
> +        RELEASE_ASSERT(m_node->isBinaryUseKind(UntypedUse));

Maybe make this a DFG_ASSERT?

[Benjamin Poulain]

(In reply to comment #3)
> > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5179
> > +        RELEASE_ASSERT(m_node->isBinaryUseKind(UntypedUse));
> 
> Maybe make this a DFG_ASSERT?

Yep, that's significantly better.

[Benjamin Poulain]

Created attachment 287155 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 287155 [details]
Patch for landing

Clearing flags on attachment: 287155

Committed r205064: <http://trac.webkit.org/changeset/205064>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.