Bug 161216 – HTMLAreaElement's coords attributes parsing does not comply with the HTML specification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification:
- https://html.spec.whatwg.org/#attr-area-coords

[Chris Dumez]

Created attachment 287028 [details]
Patch

[Andreas Kling]

Comment on attachment 287028 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 287028 [details]
Patch

Clearing flags on attachment: 287028

Committed r205030: <http://trac.webkit.org/changeset/205030>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Reopening to attach new patch.

[Chris Dumez]

Created attachment 287128 [details]
Patch

[Darin Adler]

Comment on attachment 287128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287128&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:229
> +template <typename CharacterType>
> +static inline bool isHTMLSpaceOrDelimiter(CharacterType character)
> +{
> +    return isHTMLSpace(character) || character == ',' || character == ';';
> +}
> +
> +template <typename CharacterType>
> +static inline bool isNumberStart(CharacterType character)
> +{
> +    return isASCIIDigit(character) || character == '.' || character == '-';
> +}

Is a template really needed? I think these could be be written to work on UChar and should work fine for LChar too.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:262
> +Vector<double> parseHTMLListOfOfFloatingPointNumberValues(const String& input)

Should take a StringView rather than a String.

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:266
> +    unsigned length = input.length();
> +    if (!length)
> +        return { };

This won’t be needed if the argument is a StringView.

[Chris Dumez]

Created attachment 287220 [details]
Follow-up fixes

Patch to take Darin's feedback into consideration.

[WebKit Commit Bot]

Comment on attachment 287220 [details]
Follow-up fixes

Clearing flags on attachment: 287220

Committed r205095: <http://trac.webkit.org/changeset/205095>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

*** Bug 153124 has been marked as a duplicate of this bug. ***

[zalan]

*** Bug 155516 has been marked as a duplicate of this bug. ***