Bug 161213 – Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects

Steps to Reproduce:
1. Inspect a JSContext
2. Start a Timeline Recording
3. Close inspector
  => Agents do work that is not needed (take a snapshot, process samples)

[Radar WebKit Bug Importer]

<rdar://problem/28017986>

[Joseph Pecoraro]

Created attachment 287023 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 287023 [details]
[PATCH] Proposed Fix

Attachment 287023 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1942220

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 287039 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Blaze Burg]

Comment on attachment 287023 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=287023&action=review

r=me but please make EWS happy.

> Source/JavaScriptCore/ChangeLog:11
> +        Don't take a file snapshot when disconnecting.

Nit: file snapshot? You mean heap?

[Joseph Pecoraro]

(In reply to comment #5)
> Comment on attachment 287023 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287023&action=review
> 
> r=me but please make EWS happy.
> 
> > Source/JavaScriptCore/ChangeLog:11
> > +        Don't take a file snapshot when disconnecting.
> 
> Nit: file snapshot? You mean heap?

Typo of "final".

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/205034>