Bug 161180 - Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details sidebar
Summary: Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details si...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-24 20:10 PDT by Joseph Pecoraro
Modified: 2016-08-26 14:02 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (13.44 KB, patch)
2016-08-24 20:13 PDT, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
[IMAGE] Sidebar in action (305.28 KB, image/png)
2016-08-24 20:13 PDT, Joseph Pecoraro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-08-24 20:10:28 PDT 
Summary:
Show IndexedDB Database/ObjectStore/Index data in a details sidebar.

We already have this data, lets show it:

  Database name, version, securityOrigin
  Object Store name, keyPath, autoIncrement
  Index name, keyPath, unique, multiEntry
Comment 1 Radar WebKit Bug Importer 2016-08-24 20:10:39 PDT 
<rdar://problem/28003417>
Comment 2 Joseph Pecoraro 2016-08-24 20:13:27 PDT 
Created attachment 286938 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-08-24 20:13:52 PDT 
Created attachment 286939 [details]
[IMAGE] Sidebar in action
Comment 4 Brady Eidson 2016-08-24 21:36:30 PDT 
Will review once it applies :)
Comment 5 Joseph Pecoraro 2016-08-25 00:14:00 PDT 
It will never apply because localizedStrings.js :/
Comment 6 BJ Burg 2016-08-25 15:59:33 PDT 
Comment on attachment 286938 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=286938&action=review

LGTM. Maybe post a screenshot for Brady?

> Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:116
> +            this._objectStoreAutoIncrementRow.value = this._objectStore.autoIncrement ? WebInspector.UIString("Yes") : WebInspector.UIString("No");

Hahah, the localizers will hate this. I filed a bug to add a long description to UIString, but never found time to work on it.
Comment 7 Joseph Pecoraro 2016-08-26 14:02:02 PDT 
<https://trac.webkit.org/changeset/205043>