Summary: Test and address issues in IndexedDB.requestData. This exists in the protocol, but is currently unused and untested. Testing it found some issues which were easy to fix.
<rdar://problem/28002467>
(In reply to comment #0) > but is currently unused That was wrong. Its basic functionality is used. Other functionality (key ranges) is not used. And some functionality (pagination) is broken. This tests everything.
Created attachment 286930 [details] [PATCH] Proposed Fix Blocked on other patches still up for review.
Comment on attachment 286930 [details] [PATCH] Proposed Fix Attachment 286930 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1937405 New failing tests: inspector/indexeddb/requestData.html
Created attachment 286934 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 286930 [details] [PATCH] Proposed Fix Attachment 286930 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1937408 New failing tests: inspector/indexeddb/requestData.html
Created attachment 286936 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 286930 [details] [PATCH] Proposed Fix Attachment 286930 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1937406 New failing tests: inspector/indexeddb/requestData.html
Created attachment 286937 [details] Archive of layout-test-results from ews113 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 286930 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=286930&action=review r- because of the real names issue. The rest looks pretty good and thorough, EWS notwithstanding. > LayoutTests/inspector/indexeddb/requestData-expected.txt:12 > +PASS: Value should be a remote object for: 'Timothy Hatcher' Please don't use real data/names in layout tests. > LayoutTests/inspector/indexeddb/requestData.html:24 > + // <https://webkit.org/b/148006> Each test should run with its own clean data store Same comment as in other patches. > Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:509 > + Ref<OpenCursorCallback> openCursorCallback = OpenCursorCallback::create(m_injectedScript, m_requestCallback.copyRef(), m_skipCount, m_pageSize); Ouch!
Created attachment 287061 [details] [PATCH] Proposed Fix Updated names (in the other patch and used in this one).
Comment on attachment 287061 [details] [PATCH] Proposed Fix Attachment 287061 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1943344 New failing tests: inspector/indexeddb/requestData.html
Created attachment 287067 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 287061 [details] [PATCH] Proposed Fix Attachment 287061 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1943333 New failing tests: inspector/indexeddb/requestData.html
Created attachment 287068 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 287061 [details] [PATCH] Proposed Fix Attachment 287061 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1943504 New failing tests: inspector/indexeddb/requestData.html
Created attachment 287069 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 287061 [details] [PATCH] Proposed Fix r=me, thanks ;-)
<https://trac.webkit.org/changeset/205042>