Bug 161174 – Land support for tokenization in the new CSS Parser

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

Land support for tokenization in the new CSS Parser. Bring along as much as is needed to get that going.

[Dave Hyatt]

Created attachment 286909 [details]
Patch

[WebKit Commit Bot]

Attachment 286909 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSMarkup.cpp:94:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/css/CSSMarkup.cpp:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/css/CSSMarkup.cpp:118:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSParserTokenRange.h:44:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserTokenRange.h:45:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserTokenRange.h:95:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserTokenRange.h:96:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:62:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:93:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:150:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/css/parser/CSSParserObserver.h:38:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSParserFastPaths.cpp:38:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/CMakeLists.txt:1414:  Alphabetical sorting problem. "css/parser/CSSParserFastPaths.cpp" should be before "css/parser/CSSParserValues.cpp".  [list/order] [5]
ERROR: Source/WebCore/css/parser/CSSTokenizer.h:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.cpp:42:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.cpp:72:  Wrong number of spaces before statement. (expected: 4)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.cpp:87:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.cpp:513:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.cpp:631:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.cpp:825:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebCore/css/parser/CSSPropertyParserHelpers.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:47:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:49:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:55:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:57:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:65:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:85:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:93:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:103:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:113:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:115:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:131:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:145:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:147:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:149:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:171:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:173:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:189:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:351:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:352:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:355:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:356:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:360:  Wrong number of spaces before statement. (expected: 16)  [whitespace/indent] [4]
Total errors found: 49 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 286909 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286909&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * CMakeLists.txt:

You should say this comes from Blink, and cite the Blink revision.

> Source/WebCore/css/CSSMarkup.cpp:2
> +/*
> + * Copyright (C) 2003 Lars Knoll ([e-mail])

Not sure if we need to do anything with licenses. Please check.

> Source/WebCore/css/parser/CSSParserObserver.h:46
> +    // TODO(timloh): Unused, should be removed

Remove the "(timloh)" here and elsewhere.

[Build Bot]

Comment on attachment 286909 [details]
Patch

Attachment 286909 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1936944

New failing tests:
fast/css/selector-text-escape.html
fast/css/parsing-css-nonascii.html

[Build Bot]

Created attachment 286926 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Normally we don't keep the TODO, we just use FIXME or nothing at all.

[Dave Hyatt]

Created attachment 286990 [details]
Patch to fix layout tests and style stuff

[Dave Hyatt]

Created attachment 286992 [details]
Patch to fix layout tests and style stuff

[WebKit Commit Bot]

Attachment 286992 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:68:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSPropertyParser.cpp:70:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSTokenizer.h:33:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Source/WebCore/css/parser/CSSParserToken.cpp:349:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 5 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 286998 [details]
Patch to fix layout tests and style stuff

[Dave Hyatt]

Created attachment 287016 [details]
Patch

[Dave Hyatt]

Created attachment 287019 [details]
Patch

[Dave Hyatt]

Created attachment 287029 [details]
Patch

[Dave Hyatt]

Created attachment 287046 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 287046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287046&action=review

> Source/WebCore/css/CSSMarkup.cpp:4
> + * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2016 Apple Inc. All rights reserved.

This can be changed to year ranges: 2004-2012, 2016

[Dave Hyatt]

Landed in r205103.