Bug 161161 - Don't store networkLoadTiming in the disk cache
Summary: Don't store networkLoadTiming in the disk cache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-24 13:47 PDT by Johan K. Jensen
Modified: 2016-08-25 11:26 PDT (History)
8 users (show)

See Also:


Attachments
Patch (7.14 KB, patch)
2016-08-24 13:56 PDT, Johan K. Jensen
koivisto: review+
achristensen: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan K. Jensen 2016-08-24 13:47:49 PDT
The stale networkLoadTiming is not used, so save space and don't store it in the cache.
Comment 1 Johan K. Jensen 2016-08-24 13:56:09 PDT
Created attachment 286888 [details]
Patch
Comment 2 Alex Christensen 2016-08-24 15:34:24 PDT
Comment on attachment 286888 [details]
Patch

Looks good to me.  Letting Antti look at it.
Comment 3 Antti Koivisto 2016-08-25 04:29:25 PDT
We talked about this in irc. I think that the need to do this indicates the timing data shouldn't be part of the ResourceResponse in the first place. Instead it should be passed around as a separate object (in IPC and related functions).

Do we still need to do this as an intermediate step towards the desired architecture?
Comment 4 Antti Koivisto 2016-08-25 05:42:34 PDT
Comment on attachment 286888 [details]
Patch

r=me because we are currently seeing disk cache crashes due to failure to bump up cache version when this stuff was added.
Comment 5 Alex Christensen 2016-08-25 11:20:57 PDT
(In reply to comment #3)
> Do we still need to do this as an intermediate step towards the desired
> architecture?
Yep, we don't want to redo everything right now.
Comment 6 Alex Christensen 2016-08-25 11:21:14 PDT
Comment on attachment 286888 [details]
Patch

Looks good to me.  Letting Antti look at it.
Comment 7 Alex Christensen 2016-08-25 11:26:08 PDT
http://trac.webkit.org/changeset/204977