LayoutTest js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html is a flaky failure https://build.webkit.org/builders/Apple%20Yosemite%20Release%20WK2%20(Tests)/builds/17320 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fprototype-chain-caching-with-impure-get-own-property-slot-traps-5.html --- /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt +++ /Volumes/Data/slave/yosemite-release-tests-wk2/build/layout-test-results/js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-actual.txt @@ -48,8 +48,8 @@ PASS typeof f() is "function" PASS typeof f() is "function" PASS typeof f() is "function" -PASS typeof f() is "object" -PASS typeof f() is "object" +FAIL typeof f() should be object. Was function. +FAIL typeof f() should be object. Was function. PASS typeof f() is "object" PASS typeof f() is "object" PASS typeof f() is "object"
Marked test as flaky on mac in http://trac.webkit.org/projects/webkit/changeset/205196
Oh this is a real regression. We're not clearing the inline cache in time sometimes!
<rdar://problem/28116283>
Created attachment 312334 [details] the patch
Landed in https://trac.webkit.org/changeset/217944/webkit
The test is missing an expectation file. Is this intentional?
(In reply to Claudio Saavedra from comment #6) > The test is missing an expectation file. Is this intentional? I don't think so. We should add expectation file.
(In reply to Yusuke Suzuki from comment #7) > (In reply to Claudio Saavedra from comment #6) > > The test is missing an expectation file. Is this intentional? > > I don't think so. We should add expectation file. I went ahead and added one in https://trac.webkit.org/changeset/218013/webkit
platform/Mac/TestExpectations still has js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html listed as [ Pass Failure ], pointing to this bug. Can we remove it from the list now?
(In reply to Sam Weinig from comment #9) > platform/Mac/TestExpectations still has > js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5. > html listed as [ Pass Failure ], pointing to this bug. Can we remove it from > the list now? I went ahead and did this: https://trac.webkit.org/changeset/218122/webkit
(In reply to Saam Barati from comment #10) > (In reply to Sam Weinig from comment #9) > > platform/Mac/TestExpectations still has > > js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5. > > html listed as [ Pass Failure ], pointing to this bug. Can we remove it from > > the list now? > > I went ahead and did this: > https://trac.webkit.org/changeset/218122/webkit Cool cool.