Bug 161140 - [Win] run-api-tests is failing.
Summary: [Win] run-api-tests is failing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-24 07:58 PDT by Per Arne Vollan
Modified: 2016-08-25 09:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2016-08-24 08:23 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2016-08-25 07:07 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-08-24 07:58:31 PDT
The run-api-tests script is failing with the message:

C:\cygwin\home\buildbot\slave\win-release\build\Tools\TestWebKitAPI\Tests\WTF\CrossThreadTask.cpp:126
Value of: moveConstructorSet.size()
  Actual: 9
Expected: 6u
Which is: 6
Comment 1 Per Arne Vollan 2016-08-24 08:23:55 PDT
Created attachment 286854 [details]
Patch
Comment 2 Brent Fulgham 2016-08-24 09:32:27 PDT
This seems like a reasonable conclusion. Anders, do you have any objection to this?
Comment 3 Brent Fulgham 2016-08-24 09:32:42 PDT
Comment on attachment 286854 [details]
Patch

r=me.
Comment 4 Per Arne Vollan 2016-08-24 23:31:16 PDT
Thanks for reviewing!
Comment 5 WebKit Commit Bot 2016-08-24 23:52:49 PDT
Comment on attachment 286854 [details]
Patch

Clearing flags on attachment: 286854

Committed r204957: <http://trac.webkit.org/changeset/204957>
Comment 6 WebKit Commit Bot 2016-08-24 23:52:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Per Arne Vollan 2016-08-25 06:50:17 PDT
We have one more issue:

C:\cygwin\home\buildbot\slave\win-release\build\Tools\TestWebKitAPI\Tests\WTF\CrossThreadTask.cpp:140
Value of: totalDestructorCalls
  Actual: 15
Expected: 12u
Which is: 12
Comment 8 Per Arne Vollan 2016-08-25 07:07:11 PDT
Created attachment 286966 [details]
Patch
Comment 9 Brent Fulgham 2016-08-25 08:48:12 PDT
Comment on attachment 286966 [details]
Patch

r=me
Comment 10 Per Arne Vollan 2016-08-25 08:58:51 PDT
(In reply to comment #9)
> Comment on attachment 286966 [details]
> Patch
> 
> r=me

Thanks!
Comment 11 WebKit Commit Bot 2016-08-25 09:20:08 PDT
Comment on attachment 286966 [details]
Patch

Clearing flags on attachment: 286966

Committed r204966: <http://trac.webkit.org/changeset/204966>
Comment 12 WebKit Commit Bot 2016-08-25 09:20:12 PDT
All reviewed patches have been landed.  Closing bug.