Bug 161138 - AssemblyHelpers::emitAllocateWithNonNullAllocator() crashes in the FTL on ARM64
Summary: AssemblyHelpers::emitAllocateWithNonNullAllocator() crashes in the FTL on ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-24 06:56 PDT by Filip Pizlo
Modified: 2016-08-24 09:25 PDT (History)
5 users (show)

See Also:

Attachments
the patch (1.83 KB, patch)
2016-08-24 06:57 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-08-24 06:56:34 PDT 
The FTL expects that this method can be used with scratch registers disallowed, but it uses addPtr(Addr, Reg).

The solution is to not use addPtr(Addr, Reg).
Comment 1 Filip Pizlo 2016-08-24 06:57:53 PDT 
Created attachment 286851 [details]
the patch
Comment 2 WebKit Commit Bot 2016-08-24 09:25:25 PDT 
Comment on attachment 286851 [details]
the patch

Clearing flags on attachment: 286851

Committed r204897: <http://trac.webkit.org/changeset/204897>
Comment 3 WebKit Commit Bot 2016-08-24 09:25:29 PDT 
All reviewed patches have been landed.  Closing bug.