Bug 161136 - More cleanup for the mpadded implementation
Summary: More cleanup for the mpadded implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords:
Depends on:
Blocks: 155879
  Show dependency treegraph
 
Reported: 2016-08-24 06:31 PDT by Frédéric Wang (:fredw)
Modified: 2016-08-28 01:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (11.53 KB, patch)
2016-08-24 06:47 PDT, Frédéric Wang (:fredw)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2016-08-24 06:31:47 PDT
It seems that the m_ascent member is not really needed as the ascent can be easily calculated in firstLineBaseLine() after some adjustment with how the attribute values are resolved. I was not able to find a testcase that shows how it improves dynamic update. Actually, it seems that we no longer need to override styleDidChange and updateFromElement so I'll remove them in that bug too.
Comment 1 Frédéric Wang (:fredw) 2016-08-24 06:47:20 PDT
Created attachment 286850 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-28 01:27:55 PDT
Comment on attachment 286850 [details]
Patch

Clearing flags on attachment: 286850

Committed r205098: <http://trac.webkit.org/changeset/205098>
Comment 3 WebKit Commit Bot 2016-08-28 01:28:02 PDT
All reviewed patches have been landed.  Closing bug.