[GTK] Use dbus-run-session to avoid left-over dbus-daemon instances
There are tons of dbus-launch left-overs on buildbots that run the gtk API tests. We should use dbus-run-session if possible, which is designed for this use case and should be more dependable regarding left-overs. However, it does not work like dbus-launch, by printing out the environment for the bus, it needs to be used as a prefix for the executable, so it would require a bit of a refactoring.
Created attachment 286883 [details] Patch
If you don't select the right component, we don't notice the bug!
Do we have to keep the fallback codepath? Is dbus-run-session relatively new (unavailable in Ubuntu 14.04 or Debian Jessie)? If not, let's clean up the old code too.
(In reply to comment #1) > There are tons of dbus-launch left-overs on buildbots that run the gtk API > tests. We should use dbus-run-session if possible, which is designed for > this use case and should be more dependable regarding left-overs. However, > it does not work like dbus-launch, by printing out the environment for the > bus, it needs to be used as a prefix for the executable, so it would require > a bit of a refactoring. You can set this environment variable on the bot: WEBKITBOT_TASKSTOKILL=dbus-daemon It will try to kill any process with that name. Check: https://trac.webkit.org/changeset/195587 But the above is an ugly hack, your patch address this issue better.
(In reply to comment #3) > If you don't select the right component, we don't notice the bug! Sorry, out of practice =/ I thought the [GTK] prefix was the main indication still. (In reply to comment #4) > Do we have to keep the fallback codepath? Is dbus-run-session relatively new > (unavailable in Ubuntu 14.04 or Debian Jessie)? If not, let's clean up the > old code too. Yes. I left the old code path there because it is fairly new. It's available in jessie but not ubuntu 14.04.
Comment on attachment 286883 [details] Patch Sorry it got missed
WONTFIXing this based on discussion in bug #161481