Bug 161124 - [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
Summary: [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 18:55 PDT by Simon Fraser (smfr)
Modified: 2016-08-24 13:55 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.02 KB, patch)
2016-08-23 18:57 PDT, Simon Fraser (smfr) 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-08-23 18:55:24 PDT 
[iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
Comment 1 Simon Fraser (smfr) 2016-08-23 18:57:53 PDT 
Created attachment 286821 [details]
Patch
Comment 2 Daniel Bates 2016-08-24 10:09:40 PDT 
Comment on attachment 286821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286821&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:181
> -WebFrame *mainFrame = 0;
> +WebFrame *mainFrame;

Is this correct? Notice that this variable has external linkage. From what I recall, only variables with static storage duration are guaranteed to be zero initialized.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:186
> -WebFrame *topLoadingFrame = nil;     // !nil iff a load is in progress
> +WebFrame *topLoadingFrame; // !nil iff a load is in progress

Ditto.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:189
> +CFMutableSetRef disallowedURLs;

Ditto.

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:224
> +UIWebBrowserView *gWebBrowserView;
> +UIWebScrollView *gWebScrollView;
> +DumpRenderTreeWindow *gDrtWindow;

Ditto.
Comment 3 Simon Fraser (smfr) 2016-08-24 13:55:33 PDT 
https://trac.webkit.org/r204929