Bug 161123 - Create a phony WebKitLegacy framework that the WebCoreTestSupport dylib can find
Summary: Create a phony WebKitLegacy framework that the WebCoreTestSupport dylib can find
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 18:51 PDT by Anders Carlsson
Modified: 2016-08-23 19:21 PDT (History)
0 users

See Also:

Attachments
Patch (9.89 KB, patch)
2016-08-23 18:53 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2016-08-23 18:55 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (4.42 KB, patch)
2016-08-23 18:59 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-08-23 18:51:18 PDT 
Create a phony WebKitLegacy framework that the WebCoreTestSupport dylib can find
Comment 1 Anders Carlsson 2016-08-23 18:53:21 PDT 
Created attachment 286818 [details]
Patch
Comment 2 mitz 2016-08-23 18:55:15 PDT 
Comment on attachment 286818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286818&action=review

r=me with one fix

> Source/WebCore/Configurations/WebCore.xcconfig:64
> +WK_IOS_BINCOMPAT_LDFLAGS_V9_0 = -Wl,-reexport_library,-F$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/PhonyWebKitLegacy/WebKitLegacy.framework/WebKitLegacy.tbd;

-F snuck into there.
Comment 3 Anders Carlsson 2016-08-23 18:55:48 PDT 
Created attachment 286820 [details]
Patch
Comment 4 Anders Carlsson 2016-08-23 18:59:44 PDT 
Created attachment 286822 [details]
Patch
Comment 5 Anders Carlsson 2016-08-23 19:21:36 PDT 
Committed r204879: <http://trac.webkit.org/changeset/204879>