Bug 161122 - Web Inspector: Test IndexedDB.requestDatabase
Summary: Web Inspector: Test IndexedDB.requestDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-08-23 18:07 PDT by Joseph Pecoraro
Modified: 2016-08-26 14:01 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (16.08 KB, patch)
2016-08-23 18:08 PDT, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-08-23 18:07:14 PDT 
Summary:
Test IndexedDB.requestDatabase.

Also use this opportunity to share some code across indexed db tests.
Comment 1 Joseph Pecoraro 2016-08-23 18:08:38 PDT 
Created attachment 286811 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2016-08-25 15:06:16 PDT 
Comment on attachment 286811 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=286811&action=review

r=me, looks fine. But please rebase and run through EWS before landing.

> LayoutTests/inspector/indexeddb/requestDatabase.html:12
> +        name: "ClearDatabases",

It might make sense to make this a helper method and configure each test case's 'setup' parameter to run it. Then we won't even need to rebase test results when the workaround is removed.

> LayoutTests/inspector/indexeddb/requestDatabase.html:65
> +                InspectorTest.expectThat(objectStores[2].indexes.length === 2, "Object store should have 2 indexes.");

I really appreciate the good messages in these expectations.

> LayoutTests/inspector/indexeddb/requestDatabase.html:74
> +    // FIXME: <https://webkit.org/b/161121> Web Inspector: IndexedDB.requestDatabase() should not create a database if one did not exist

Oops.
Comment 3 Joseph Pecoraro 2016-08-26 14:01:24 PDT 
<https://trac.webkit.org/changeset/205040>