VO for macOS speaks "checked" appropriately. iOS does not. <rdar://problem/27975170>
Created attachment 286806 [details] Patch
Comment on attachment 286806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286806&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1250 > + if (m_object->isCheckboxOrRadio() || m_object->isMenuItem()) { does this also have the toggleTrait? if not, then VO would probably speak "1" as the value instead of off/on
Comment on attachment 286806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286806&action=review >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1250 >> + if (m_object->isCheckboxOrRadio() || m_object->isMenuItem()) { > > does this also have the toggleTrait? if not, then VO would probably speak "1" as the value instead of off/on This is same as how we expose the value on Mac. But I can double check for the traits.
Yea iOS is different If we use the 0,1,2 values we need to make sure that object is using the toggle trait (In reply to comment #3) > Comment on attachment 286806 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286806&action=review > > >> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1250 > >> + if (m_object->isCheckboxOrRadio() || m_object->isMenuItem()) { > > > > does this also have the toggleTrait? if not, then VO would probably speak "1" as the value instead of off/on > > This is same as how we expose the value on Mac. But I can double check for > the traits.
Created attachment 286878 [details] patch Added toggle trait
Comment on attachment 286878 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=286878&action=review > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1252 > + if (m_object->isCheckboxOrRadio() || m_object->roleValue() == MenuItemCheckboxRole || m_object->roleValue() == MenuItemRadioRole) { we should put the roleValue into a local variable probably, otherwise looks good
Created attachment 286895 [details] patch Update from review
Comment on attachment 286895 [details] patch Clearing flags on attachment: 286895 Committed r204938: <http://trac.webkit.org/changeset/204938>
All reviewed patches have been landed. Closing bug.