Bug 161108 - AX: Add test for line text marker range on iOS
Summary: AX: Add test for line text marker range on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-23 14:55 PDT by Nan Wang
Modified: 2016-08-24 11:14 PDT (History)
11 users (show)

See Also:


Attachments
patch (6.92 KB, patch)
2016-08-23 15:04 PDT, Nan Wang
cfleizach: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-08-23 14:55:26 PDT
We should add a test to verify text marker range for line works correctly on iOS.
Comment 1 Radar WebKit Bug Importer 2016-08-23 14:55:48 PDT
<rdar://problem/27976405>
Comment 2 Nan Wang 2016-08-23 15:04:08 PDT
Created attachment 286784 [details]
patch
Comment 3 chris fleizach 2016-08-23 18:06:50 PDT
Comment on attachment 286784 [details]
patch

is this ready to review?
Comment 4 Nan Wang 2016-08-23 18:09:25 PDT
(In reply to comment #3)
> Comment on attachment 286784 [details]
> patch
> 
> is this ready to review?

Yes
Comment 5 WebKit Commit Bot 2016-08-24 10:17:34 PDT
Comment on attachment 286784 [details]
patch

Rejecting attachment 286784 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 286784, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   1ca05f1..8794dd3  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 204901 = 1ca05f12bbb830d7b92fc7e40b12341163352e40
r204902 = 8794dd3afd32b8b0860b2dcf262060809c6df8e1
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/1935040
Comment 6 Nan Wang 2016-08-24 11:10:34 PDT
Fixing it.
Comment 7 Nan Wang 2016-08-24 11:14:19 PDT
Committed r204906: <http://trac.webkit.org/changeset/204906>