Bug 161104 - strict mode eval should not fire the var injection watch point
Summary: strict mode eval should not fire the var injection watch point
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 14:29 PDT by Saam Barati
Modified: 2016-08-23 15:18 PDT (History)
13 users (show)

See Also:


Attachments
patch (1.55 KB, patch)
2016-08-23 14:36 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-08-23 14:29:59 PDT
...
Comment 1 Saam Barati 2016-08-23 14:31:07 PDT
It's unlikely this will make many things slower, but it might perturb code like this:
function foo() {
    eval( something that doesn't var inject );
    ... some computationally heavy things
}

function bar() {
   "use strict";
   eval("var x = 20");
}

bar();
foo();
Comment 2 Saam Barati 2016-08-23 14:36:29 PDT
Created attachment 286779 [details]
patch
Comment 3 Geoffrey Garen 2016-08-23 14:39:23 PDT
Comment on attachment 286779 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2016-08-23 15:18:29 PDT
Comment on attachment 286779 [details]
patch

Clearing flags on attachment: 286779

Committed r204861: <http://trac.webkit.org/changeset/204861>
Comment 5 WebKit Commit Bot 2016-08-23 15:18:35 PDT
All reviewed patches have been landed.  Closing bug.