Add enum traits and use them in the IPC::Decoder
Created attachment 286773 [details] Patch
Attachment 286773 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WTF/EnumTraits.cpp:31: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/EnumTraits.cpp:32: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Tools/TestWebKitAPI/Tests/WTF/EnumTraits.cpp:33: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/wtf/EnumTraits.h:59: This { should be at the end of the previous line [whitespace/braces] [4] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:58: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:546: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:548: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:551: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Shared/mac/ArgumentCodersMac.mm:553: preprocessor directives (e.g., #ifdef, #define, #import) should never be indented. [whitespace/indent] [4] ERROR: Source/WebKit2/Platform/IPC/Decoder.h:89: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 10 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 286773 [details] Patch r=me if you make sure the builds work.
Committed r204916: <http://trac.webkit.org/changeset/204916>
(In reply to comment #4) > Committed r204916: <http://trac.webkit.org/changeset/204916> It appears that this commented-out code got committed by accident: diff --git a/Source/WebKit2/UIProcess/WebPageProxy.cpp b/Source/WebKit2/UIProcess/WebPageProxy.cpp index 7cf79dd..ea472c0 100644 --- a/Source/WebKit2/UIProcess/WebPageProxy.cpp +++ b/Source/WebKit2/UIProcess/WebPageProxy.cpp @@ -2348,1 +2348,1 @@ void WebPageProxy::terminateProcess() - ASSERT(m_process->state() != WebProcessProxy::State::Launching); +// ASSERT(m_process->state() != WebProcessProxy::State::Launching); Should this specific change be reverted?
(In reply to comment #5) > (In reply to comment #4) > > Committed r204916: <http://trac.webkit.org/changeset/204916> > > It appears that this commented-out code got committed by accident: > > diff --git a/Source/WebKit2/UIProcess/WebPageProxy.cpp > b/Source/WebKit2/UIProcess/WebPageProxy.cpp > index 7cf79dd..ea472c0 100644 > --- a/Source/WebKit2/UIProcess/WebPageProxy.cpp > +++ b/Source/WebKit2/UIProcess/WebPageProxy.cpp > @@ -2348,1 +2348,1 @@ void WebPageProxy::terminateProcess() > - ASSERT(m_process->state() != WebProcessProxy::State::Launching); > +// ASSERT(m_process->state() != WebProcessProxy::State::Launching); > > Should this specific change be reverted? I filed: Bug 162077: ASSERT accidentally commented out in r204916