RESOLVED FIXED 161097
[ES6] Module namespace object's Symbol.iterator method should only accept module namespace objects 
https://bugs.webkit.org/show_bug.cgi?id=161097
Summary [ES6] Module namespace object's Symbol.iterator method should only accept mod...
Yusuke Suzuki
Reported 2016-08-23 11:36:54 PDT
[ES6] Module namespace object's Symbol.iterator method should only accept module namespace objects
Attachments
Patch (3.68 KB, patch)
2016-08-23 11:37 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-08-23 11:37:05 PDT
Created attachment 286751 [details] Patch
Keith Miller
Comment 2 2016-08-23 12:03:23 PDT
Comment on attachment 286751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286751&action=review r=me with comment. > Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp:206 > + return JSValue::encode(throwTypeError(exec, ASCIILiteral("|this| should be a module namespace object"))); This could be "return throwVMTypeError(...)" instead of "return JSValue::encode(throwTypeError(...))"
Yusuke Suzuki
Comment 3 2016-08-23 12:04:27 PDT
Comment on attachment 286751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286751&action=review Thank you :) >> Source/JavaScriptCore/runtime/JSModuleNamespaceObject.cpp:206 >> + return JSValue::encode(throwTypeError(exec, ASCIILiteral("|this| should be a module namespace object"))); > > This could be "return throwVMTypeError(...)" instead of "return JSValue::encode(throwTypeError(...))" Nice! Changed.
Yusuke Suzuki
Comment 4 2016-08-23 12:09:19 PDT
Committed r204848: <http://trac.webkit.org/changeset/204848>
Note You need to log in before you can comment on or make changes to this bug.