...
+1
Created attachment 286801 [details] patch
Comment on attachment 286801 [details] patch rs=me
Created attachment 286804 [details] sane looking patch This is the part of the patch that is important. After this, I'm going to do: ``` $ svn mv LayoutTests/js/regress/script-tests JSTests/microbenchmarks $ svn rm LayoutTests/js/regress $ prepareChangelog $ svn commit ```
landed in: https://trac.webkit.org/changeset/204870
js/regress/put-by-id-transition-with-indexing-header.html was the only test that found a recent regression. Given that it's not failing in jsc tests after the move, looks like this change reduces test coverage.
This patch removed an expectation for js/regress-139548.html, but did not remove the test. So it's now failing on the bots: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fregress-139548.html
(In reply to comment #7) > This patch removed an expectation for js/regress-139548.html, but did not > remove the test. > > So it's now failing on the bots: > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=js%2Fregress-139548.html It was a mistake to remove this expectation. Ditto for js/regress-141098.html. I will reinstate the expectations.
Test expectations for js/regress-139548.html and js/regress-141098.html were restored in r204900: <http://trac.webkit.org/r204900>.