RESOLVED FIXED 161093
Add a workaround for iOS Frameworks that expect DOM bindings to be in WebCore 
https://bugs.webkit.org/show_bug.cgi?id=161093
Summary Add a workaround for iOS Frameworks that expect DOM bindings to be in WebCore
Anders Carlsson
Reported 2016-08-23 10:52:59 PDT
Add a workaround for iOS Frameworks that expect DOM bindings to be in WebCore
Attachments
Patch (5.59 KB, patch)
2016-08-23 10:55 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (5.58 KB, patch)
2016-08-23 11:08 PDT, Anders Carlsson 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-08-23 10:55:46 PDT
Created attachment 286735 [details] Patch
Anders Carlsson
Comment 2 2016-08-23 11:08:22 PDT
Created attachment 286740 [details] Patch
mitz
Comment 3 2016-08-23 11:14:39 PDT
Comment on attachment 286740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286740&action=review > Source/WebCore/Configurations/WebKitLegacyStub.iOS.tbd:5 > +current-version: 7603.1.3 Not that it matters, but drop the leading 7. We prefix the bundle version with 7 but not the dylib version.
Anders Carlsson
Comment 4 2016-08-23 11:38:28 PDT
Committed r204843: <http://trac.webkit.org/changeset/204843>
Alexey Proskuryakov
Comment 5 2016-08-23 14:47:06 PDT
Comment on attachment 286740 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286740&action=review > Source/WebCore/ChangeLog:9 > + Create a text-based stub library that looks enough like WebKitLegacy that we can trick the linker > + into creating a LC_REEXPORT_DYLIB load command in WebCore. This looks like it may have broken iOS Device EWS. I'm not sure what's going on, as regular builders build successfully. https://webkit-queues.webkit.org/results/1930111 Ld /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/libWebCoreTestSupport.dylib normal armv7s cd /Volumes/Data/EWS/WebKit/Source/WebCore export IPHONEOS_DEPLOYMENT_TARGET=9.3 export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin" /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang++ -arch armv7s -dynamiclib -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.3.sdk -L/Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos -F/Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos -F/Volumes/Data/EWS/WebKit/Source/WebCore/../../WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/9 -filelist /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release-iphoneos/WebCoreTestSupport.build/Objects-normal/armv7s/WebCoreTestSupport.LinkFileList -unexported_symbols_list Configurations/WebCore.unexp -install_name @rpath/libWebCoreTestSupport.dylib -miphoneos-version-min=9.3 -dead_strip -lAccessibility -stdlib=libc++ -fobjc-link-runtime -framework CoreFoundation -framework JavaScriptCore -framework WebCore -single_module -compatibility_version 1 -current_version 603.1.3 -Xlinker -dependency_info -Xlinker /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release-iphoneos/WebCoreTestSupport.build/Objects-normal/armv7s/WebCoreTestSupport_dependency_info.dat -o /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphoneos/libWebCoreTestSupport.dylib ld: file not found: /System/Library/PrivateFrameworks/WebKitLegacy.framework/WebKitLegacy for architecture armv7s clang: error: linker command failed with exit code 1 (use -v to see invocation) > Source/WebCore/ChangeLog:12 > + Link against this WebKitLegacyStub tbd file on iOS 9.0, 9.3 and 10.0. Does iOS 9.0 even support .tbd stubs? That wouldn't affect EWS of course, as it's using 9.3 SDK.
Note You need to log in before you can comment on or make changes to this bug.