161090 – Remove EXTERN_C from WTF

RESOLVED FIXED 161090

Remove EXTERN_C from WTF

https://bugs.webkit.org/show_bug.cgi?id=161090

Summary Remove EXTERN_C from WTF

Daniel Bates

Reported 2016-08-23 10:25:48 PDT

Using the macro definitions WTF_EXTERN_C_BEGIN, WTF_EXTERN_C_END is preferred over EXTERN_C. We should remove the macro definition EXTERN_C.

Attachments
Patch (44.18 KB, patch) 2016-08-23 10:30 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (44.18 KB, patch) 2016-08-23 10:36 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (45.14 KB, patch) 2016-08-23 18:33 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2016-08-23 10:30:49 PDT

Created attachment 286728 [details] Patch

WebKit Commit Bot

Comment 2 2016-08-23 10:33:14 PDT

Attachment 286728 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:39: mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:40: mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:41: mach_vm_map is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:43: mach_vm_protect is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:44: mach_vm_region is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:46: mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:47: mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/dyldSPI.h:56: dyld_get_program_sdk_version is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:84: _xpc_error_connection_invalid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:85: _xpc_error_termination_imminent is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:87: _xpc_type_array is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:88: _xpc_type_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:89: _xpc_type_dictionary is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:90: _xpc_type_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:91: _xpc_type_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:93: xpc_array_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:95: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:96: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:96: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:98: xpc_array_get_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:99: xpc_array_get_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:100: xpc_array_set_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:101: xpc_bool_get_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:102: xpc_connection_cancel is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:103: xpc_connection_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:104: xpc_connection_create_mach_service is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:105: xpc_connection_get_pid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_connection_resume is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_connection_send_message is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:108: xpc_connection_send_message_with_reply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:109: xpc_connection_set_event_handler is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:110: xpc_connection_set_target_queue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:111: xpc_dictionary_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:112: xpc_dictionary_create_reply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:113: xpc_dictionary_dup_fd is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:114: xpc_dictionary_get_remote_connection is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:115: xpc_dictionary_get_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:116: xpc_dictionary_get_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:117: xpc_dictionary_get_uint64 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:118: xpc_dictionary_get_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:119: xpc_dictionary_set_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:120: xpc_dictionary_set_fd is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:121: xpc_dictionary_set_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:122: xpc_dictionary_set_uint64 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:123: xpc_dictionary_set_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:124: xpc_get_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:125: xpc_main is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:126: xpc_string_get_string_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:127: xpc_transaction_begin is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:128: xpc_transaction_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:129: xpc_transaction_exit_clean is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:130: xpc_track_activity is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:132: xpc_connection_copy_entitlement_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:133: xpc_connection_get_audit_token is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:134: xpc_connection_kill is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:135: xpc_connection_set_instance is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:136: xpc_dictionary_copy_mach_send is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:137: xpc_dictionary_set_mach_send is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:139: xpc_connection_set_bootstrap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:140: xpc_copy_bootstrap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:141: xpc_connection_set_oneshot_instance is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:148: xpc_retain is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:156: xpc_release is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h:42: _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h:43: _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 65 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 3 2016-08-23 10:36:54 PDT

Created attachment 286730 [details] Patch

WebKit Commit Bot

Comment 4 2016-08-23 10:49:51 PDT

Attachment 286730 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:39: mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:40: mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:41: mach_vm_map is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:43: mach_vm_protect is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:44: mach_vm_region is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:46: mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:47: mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/dyldSPI.h:56: dyld_get_program_sdk_version is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:84: _xpc_error_connection_invalid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:85: _xpc_error_termination_imminent is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:87: _xpc_type_array is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:88: _xpc_type_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:89: _xpc_type_dictionary is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:90: _xpc_type_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:91: _xpc_type_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:93: xpc_array_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:95: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:96: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:96: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:98: xpc_array_get_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:99: xpc_array_get_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:100: xpc_array_set_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:101: xpc_bool_get_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:102: xpc_connection_cancel is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:103: xpc_connection_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:104: xpc_connection_create_mach_service is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:105: xpc_connection_get_pid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_connection_resume is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_connection_send_message is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:108: xpc_connection_send_message_with_reply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:109: xpc_connection_set_event_handler is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:110: xpc_connection_set_target_queue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:111: xpc_dictionary_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:112: xpc_dictionary_create_reply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:113: xpc_dictionary_dup_fd is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:114: xpc_dictionary_get_remote_connection is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:115: xpc_dictionary_get_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:116: xpc_dictionary_get_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:117: xpc_dictionary_get_uint64 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:118: xpc_dictionary_get_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:119: xpc_dictionary_set_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:120: xpc_dictionary_set_fd is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:121: xpc_dictionary_set_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:122: xpc_dictionary_set_uint64 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:123: xpc_dictionary_set_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:124: xpc_get_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:125: xpc_main is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:126: xpc_string_get_string_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:127: xpc_transaction_begin is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:128: xpc_transaction_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:129: xpc_transaction_exit_clean is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:130: xpc_track_activity is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:132: xpc_connection_copy_entitlement_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:133: xpc_connection_get_audit_token is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:134: xpc_connection_kill is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:135: xpc_connection_set_instance is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:136: xpc_dictionary_copy_mach_send is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:137: xpc_dictionary_set_mach_send is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:139: xpc_connection_set_bootstrap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:140: xpc_copy_bootstrap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:141: xpc_connection_set_oneshot_instance is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:148: xpc_retain is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:156: xpc_release is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h:42: _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h:43: _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 65 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 5 2016-08-23 18:33:29 PDT

Created attachment 286815 [details] Patch

WebKit Commit Bot

Comment 6 2016-08-23 18:35:22 PDT

Attachment 286815 [details] did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:39: mach_vm_allocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:40: mach_vm_deallocate is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:41: mach_vm_map is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:43: mach_vm_protect is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:44: mach_vm_region is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:46: mach_vm_region_recurse is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cocoa/MachVMSPI.h:47: mach_vm_purgable_control is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/dyldSPI.h:56: dyld_get_program_sdk_version is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:84: _xpc_error_connection_invalid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:85: _xpc_error_termination_imminent is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:87: _xpc_type_array is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:88: _xpc_type_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:89: _xpc_type_dictionary is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:90: _xpc_type_error is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:91: _xpc_type_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:93: xpc_array_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:95: xpc_array_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:96: The parameter name "applier" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:96: xpc_dictionary_apply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:98: xpc_array_get_count is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:99: xpc_array_get_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:100: xpc_array_set_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:101: xpc_bool_get_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:102: xpc_connection_cancel is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:103: xpc_connection_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:104: xpc_connection_create_mach_service is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:105: xpc_connection_get_pid is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:106: xpc_connection_resume is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:107: xpc_connection_send_message is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:108: xpc_connection_send_message_with_reply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:109: xpc_connection_set_event_handler is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:110: xpc_connection_set_target_queue is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:111: xpc_dictionary_create is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:112: xpc_dictionary_create_reply is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:113: xpc_dictionary_dup_fd is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:114: xpc_dictionary_get_remote_connection is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:115: xpc_dictionary_get_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:116: xpc_dictionary_get_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:117: xpc_dictionary_get_uint64 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:118: xpc_dictionary_get_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:119: xpc_dictionary_set_bool is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:120: xpc_dictionary_set_fd is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:121: xpc_dictionary_set_string is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:122: xpc_dictionary_set_uint64 is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:123: xpc_dictionary_set_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:124: xpc_get_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:125: xpc_main is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:126: xpc_string_get_string_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:127: xpc_transaction_begin is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:128: xpc_transaction_end is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:129: xpc_transaction_exit_clean is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:130: xpc_track_activity is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:132: xpc_connection_copy_entitlement_value is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:133: xpc_connection_get_audit_token is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:134: xpc_connection_kill is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:135: xpc_connection_set_instance is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:136: xpc_dictionary_copy_mach_send is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:137: xpc_dictionary_set_mach_send is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:139: xpc_connection_set_bootstrap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:140: xpc_copy_bootstrap is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:141: xpc_connection_set_oneshot_instance is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:148: xpc_retain is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/spi/darwin/XPCSPI.h:156: xpc_release is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h:42: _CFNetworkHTTPConnectionCacheGetLimit is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WebCore/platform/spi/cf/CFNetworkConnectionCacheSPI.h:43: _CFNetworkHTTPConnectionCacheSetLimit is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 65 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 7 2016-08-25 12:33:10 PDT

Comment on attachment 286815 [details] Patch r=me.

Daniel Bates

Comment 8 2016-09-06 10:19:10 PDT

Comment on attachment 286815 [details] Patch Clearing flags on attachment: 286815 Committed r205488: <http://trac.webkit.org/changeset/205488>

Daniel Bates

Comment 9 2016-09-06 10:19:15 PDT

All reviewed patches have been landed. Closing bug.

Daniel Bates

Comment 10 2016-09-06 11:05:26 PDT

Committed Apple-internal build fix in <http://trac.webkit.org/changeset/205492>.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Local Build

Hardware All

OS All

Product WebKit

Component Web Template Framework

Assignee

Daniel Bates

Reported

2016-08-23 10:25 PDT

Modified

2016-09-06 11:05 PDT History

CC List

5 users Show

URL

Keywords

Depends on

Blocks