Bug 161077 - [Win] Warning fixes.
Summary: [Win] Warning fixes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 03:57 PDT by Per Arne Vollan
Modified: 2016-08-26 06:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.92 KB, patch)
2016-08-23 04:17 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (10.37 KB, patch)
2016-08-23 06:36 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (10.29 KB, patch)
2016-08-23 10:00 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-08-23 03:57:05 PDT 
There are still a few warnings left in WebCore.
Comment 1 Per Arne Vollan 2016-08-23 04:17:12 PDT 
Created attachment 286698 [details]
Patch
Comment 2 Per Arne Vollan 2016-08-23 06:36:36 PDT 
Created attachment 286708 [details]
Patch
Comment 3 Per Arne Vollan 2016-08-23 06:41:20 PDT 
Index: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
===================================================================
--- Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	(revision 204814)
+++ Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	(working copy)
@@ -392,6 +392,8 @@ void GraphicsLayerCA::initialize(Type la
     case Type::Shape:
         platformLayerType = PlatformCALayer::LayerType::LayerTypeShapeLayer;
         break;
+    default:
+        RELEASE_ASSERT_NOT_REACHED();
     }
     m_layer = createPlatformCALayer(platformLayerType, this);
     noteLayerPropertyChanged(ContentsScaleChanged);

Would it be better to just return here?
Comment 4 Per Arne Vollan 2016-08-23 10:00:05 PDT 
Created attachment 286723 [details]
Patch
Comment 5 Brent Fulgham 2016-08-25 12:34:20 PDT 
Comment on attachment 286723 [details]
Patch

Nice! We're getting so close to zero warnings! :-) r=me.
Comment 6 Per Arne Vollan 2016-08-26 06:08:59 PDT 
Thanks for reviewing!
Comment 7 WebKit Commit Bot 2016-08-26 06:31:18 PDT 
Comment on attachment 286723 [details]
Patch

Clearing flags on attachment: 286723

Committed r205011: <http://trac.webkit.org/changeset/205011>
Comment 8 WebKit Commit Bot 2016-08-26 06:31:22 PDT 
All reviewed patches have been landed.  Closing bug.