Bug 161076 - DOMTokenList’s value and stringifier should not return parsed tokens
Summary: DOMTokenList’s value and stringifier should not return parsed tokens
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-23 00:32 PDT by Ryosuke Niwa
Modified: 2016-09-28 16:37 PDT (History)
6 users (show)

See Also:


Attachments
Patch (16.40 KB, patch)
2016-08-23 00:44 PDT, Ryosuke Niwa
cdumez: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-08-23 00:32:09 PDT
The latest DOM spec requires that we forward call getAttribute/setAttribute to get and set value and stringify DOMTokenList.
Comment 1 Ryosuke Niwa 2016-08-23 00:44:06 PDT
Created attachment 286688 [details]
Patch
Comment 2 Chris Dumez 2016-08-23 07:02:03 PDT
Comment on attachment 286688 [details]
Patch

The spec has changed recently after we implemented it. I am working on getting the spec back the way it was. Our current behavior is nicer, this patch makes it worse.
Comment 4 Chris Dumez 2016-08-23 07:36:25 PDT
Let's discuss today in person.
Comment 5 Chris Dumez 2016-08-24 15:15:38 PDT
Comment on attachment 286688 [details]
Patch

r=me. Looks like getting the spec changed back is going to be difficult.
Comment 6 WebKit Commit Bot 2016-08-27 17:27:09 PDT
Comment on attachment 286688 [details]
Patch

Rejecting attachment 286688 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 286688, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Log
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/imported/w3c/web-platform-tests/dom/lists/DOMTokenList-stringifier-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/lists/DOMTokenList-value-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1956506
Comment 7 Chris Dumez 2016-09-27 21:12:00 PDT
Ryosuke, I think we can land this, no?
Comment 8 Ryosuke Niwa 2016-09-27 21:21:17 PDT
(In reply to comment #7)
> Ryosuke, I think we can land this, no?

Oh, I didn't realize that this patch hadn't been landed. I guess CQ failed?
Comment 9 Chris Dumez 2016-09-27 21:22:05 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > Ryosuke, I think we can land this, no?
> 
> Oh, I didn't realize that this patch hadn't been landed. I guess CQ failed?

Looks like the CQ failed because the patch needs rebasing, yes.
Comment 10 Ryosuke Niwa 2016-09-27 21:25:37 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > Ryosuke, I think we can land this, no?
> > 
> > Oh, I didn't realize that this patch hadn't been landed. I guess CQ failed?
> 
> Looks like the CQ failed because the patch needs rebasing, yes.

Okay, let me rebase & land it tomorrow morning. Or feel free to land it if you'd like.
Comment 11 Ryosuke Niwa 2016-09-28 16:37:15 PDT
Committed r206560: <http://trac.webkit.org/changeset/206560>