Based on https://bugs.webkit.org/show_bug.cgi?id=160893#c8
<rdar://problem/27961661>
Created attachment 286783 [details] Patch So I tried doing this, but it seems like trying to add extra styling based on a <use> doesn't want to work. All the icons just appear as black rounded rectangles...
Darn. At a quick glance this looks correct to me.
Created attachment 288540 [details] Patch
Comment on attachment 288540 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288540&action=review r- to handle the GTK images, but otherwise the patch looks good! > Source/WebInspectorUI/UserInterface/Images/StyleRule.svg:41 > + --background: rgb(224, 224, 224); > + --border: rgb(178, 178, 178); > + --outline: rgb(191, 191, 191); Using variables here is not just clever it was apparently necessary (can't just do #id .class { fill: ... }). You should have a sentence explaining this in the ChangeLog, because it is non-trivial to someone reading the file. > Source/WebInspectorUI/UserInterface/Views/StyleRuleIcons.css:61 > .inherited-style-rule-icon .icon { > - content: url(../Images/StyleRuleInherited.svg); > + content: url(../Images/StyleRule.svg#inherited); > } This is awesome! But it does means you have to handle the GTK images as well, to either update them to work with this or an override: :not(.mac-platform, .windows-platform) .inherited-style-rule-icon .icon { ... } I'd prefer if we can update their images as well, it would keep this CSS slim.
Created attachment 288545 [details] Patch
Comment on attachment 288545 [details] Patch r=me
Comment on attachment 288545 [details] Patch Clearing flags on attachment: 288545 Committed r205793: <http://trac.webkit.org/changeset/205793>
All reviewed patches have been landed. Closing bug.