Bug 161061 - Drop TextTrackCue's constructor as per the latest specification
Summary: Drop TextTrackCue's constructor as per the latest specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/#texttra...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-08-22 15:34 PDT by Chris Dumez
Modified: 2016-08-22 23:45 PDT (History)
7 users (show)

See Also:


Attachments
Patch (45.17 KB, patch)
2016-08-22 16:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2 (689.71 KB, application/zip)
2016-08-22 19:12 PDT, Build Bot
no flags Details
Patch (47.99 KB, patch)
2016-08-22 19:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-22 15:34:41 PDT
Drop TextTrackCue's constructor as per the latest specification:
- https://html.spec.whatwg.org/#texttrackcue

Firefox and Chrome do not have this constructor.
Comment 1 Chris Dumez 2016-08-22 15:38:21 PDT
Blink's intent to remove:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/R34xpMQGtXU/XwXsi85Y7acJ
Comment 2 Chris Dumez 2016-08-22 15:40:17 PDT
People should use the VTTCue constructor instead, which we support.
Comment 3 Chris Dumez 2016-08-22 16:09:21 PDT
Created attachment 286635 [details]
Patch
Comment 4 Build Bot 2016-08-22 19:12:42 PDT
Comment on attachment 286635 [details]
Patch

Attachment 286635 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1924529

New failing tests:
js/dom/constructor-length.html
Comment 5 Build Bot 2016-08-22 19:12:45 PDT
Created attachment 286648 [details]
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5
Comment 6 Chris Dumez 2016-08-22 19:23:28 PDT
Created attachment 286652 [details]
Patch
Comment 7 WebKit Commit Bot 2016-08-22 23:45:49 PDT
Comment on attachment 286652 [details]
Patch

Clearing flags on attachment: 286652

Committed r204765: <http://trac.webkit.org/changeset/204765>
Comment 8 WebKit Commit Bot 2016-08-22 23:45:54 PDT
All reviewed patches have been landed.  Closing bug.