Bug 16105 - NetscapePlugInStreamLoader has unnecessary #ifs for CFNETWORK
Summary: NetscapePlugInStreamLoader has unnecessary #ifs for CFNETWORK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-23 14:21 PST by Rodney Dawes
Modified: 2007-11-25 18:38 PST (History)
0 users

See Also:


Attachments
Patch to not disable portions of the API without CFNETWORK (1.92 KB, patch)
2007-11-23 14:21 PST, Rodney Dawes
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rodney Dawes 2007-11-23 14:21:00 PST
Portions of the API in NetscapePlugInStreamLoader.h are #ifed out with checks for CFNETWORK, while CFNETWORK is not required to implement the API in a platform class. The attached patch fixes this.
Comment 1 Rodney Dawes 2007-11-23 14:21:35 PST
Created attachment 17472 [details]
Patch to not disable portions of the API without CFNETWORK
Comment 2 Alp Toker 2007-11-23 15:50:01 PST
I think the ChangeLog needs to be updated with an explanation of why the conditional checks are no longer needed. Can you check SVN history to find out why they were put there to begin with, and if any build configuration still needs them?
Comment 3 Maciej Stachowiak 2007-11-24 19:09:15 PST
Comment on attachment 17472 [details]
Patch to not disable portions of the API without CFNETWORK

If this doesn't break any builds, r=me.
Comment 4 Mark Rowe (bdash) 2007-11-25 18:38:35 PST
Landed in r28029 after tweaking it to not break the build.

Rodney, can you please leave the "Reviewed by NOBODY (OOPS!)" line in your changelog entries in the future?  It helps ensure that the committer adds the reviewer's name as our pre-commit hooks will catch the "NOBDOY (OOPS!)".