WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161047
REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
https://bugs.webkit.org/show_bug.cgi?id=161047
Summary
REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
Alexey Proskuryakov
Reported
2016-08-22 10:26:49 PDT
PHP 5.6 now sends a charset in Content-Type by default, which our tests don't expect. Since we need fine-grained control over HTTP headers in testing, let's change the behavior back. An alternative would be to call ini_set(default_charset, "") in all affected tests, but I don't know how to identify them.
rdar://problem/27434307
Attachments
proposed fix
(3.59 KB, patch)
2016-08-22 10:32 PDT
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2016-08-22 10:32:48 PDT
Created
attachment 286604
[details]
proposed fix
WebKit Commit Bot
Comment 2
2016-08-23 12:14:19 PDT
Comment on
attachment 286604
[details]
proposed fix Clearing flags on attachment: 286604 Committed
r204850
: <
http://trac.webkit.org/changeset/204850
>
WebKit Commit Bot
Comment 3
2016-08-23 12:14:29 PDT
All reviewed patches have been landed. Closing bug.
Brent Fulgham
Comment 4
2016-08-24 09:24:31 PDT
This breaks the Windows test bots.
Brent Fulgham
Comment 5
2016-08-24 09:30:15 PDT
(In reply to
comment #4
)
> This breaks the Windows test bots.
Build fix proposed in
Bug 161134
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug