Bug 161041 - [ES6] Module should not allow HTML comments
Summary: [ES6] Module should not allow HTML comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-21 22:14 PDT by Yusuke Suzuki
Modified: 2016-08-22 07:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (48.95 KB, patch)
2016-08-21 22:30 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2016-08-21 22:14:35 PDT 
[ES6] Module should not allow HTML comments
Comment 1 Yusuke Suzuki 2016-08-21 22:30:41 PDT 
Created attachment 286586 [details]
Patch
Comment 2 Saam Barati 2016-08-22 00:12:41 PDT 
Comment on attachment 286586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286586&action=review

> Source/JavaScriptCore/parser/ParserModes.h:36
> +enum class JSParserScriptMode { Classic, Module };

I propose calling this "JSParserCommentMode" or something to better indicate its use case.
Comment 3 Yusuke Suzuki 2016-08-22 06:47:13 PDT 
Comment on attachment 286586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286586&action=review

Thanks!

>> Source/JavaScriptCore/parser/ParserModes.h:36
>> +enum class JSParserScriptMode { Classic, Module };
> 
> I propose calling this "JSParserCommentMode" or something to better indicate its use case.

Sounds nice. Fixed.
Comment 4 Yusuke Suzuki 2016-08-22 07:13:56 PDT 
Committed r204714: <http://trac.webkit.org/changeset/204714>