Bug 161039 – Remove a few custom bindings

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove a few custom bindings

[Sam Weinig]

Created attachment 286577 [details]
Patch

[Sam Weinig]

Created attachment 286579 [details]
Patch

[Sam Weinig]

Created attachment 286580 [details]
Patch

[Darin Adler]

Comment on attachment 286580 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286580&action=review

Looks good! Not sure why it’s not building.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.h:86
> +    const Vector<float>& webkitLineDash() const { return getLineDash(); }
>      void setWebkitLineDash(const Vector<float>&);

Strange that get is inlined but set is not.

[Sam Weinig]

Created attachment 286581 [details]
Patch

[Sam Weinig]

(In reply to comment #4)
> Comment on attachment 286580 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=286580&action=review
> 
> Looks good! Not sure why it’s not building.
> 
> > Source/WebCore/html/canvas/CanvasRenderingContext2D.h:86
> > +    const Vector<float>& webkitLineDash() const { return getLineDash(); }
> >      void setWebkitLineDash(const Vector<float>&);
> 
> Strange that get is inlined but set is not.

Get is identical, set has slightly different semantics, and therefore can't just forward.  If they were both identical, I would remove them, and make the bindings forward, but alas, this is the world we live in.

[Sam Weinig]

I was being greedy trying to do two interfaces at once. Latest patch just fixes the canvas interface.

[WebKit Commit Bot]

Comment on attachment 286581 [details]
Patch

Clearing flags on attachment: 286581

Committed r204700: <http://trac.webkit.org/changeset/204700>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.