WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161032
Stop pretending that AbstractView is a thing, it's not
https://bugs.webkit.org/show_bug.cgi?id=161032
Summary
Stop pretending that AbstractView is a thing, it's not
Sam Weinig
Reported
2016-08-20 11:05:00 PDT
Stop pretending that AbstractView is a thing, it's not
Attachments
Patch
(47.20 KB, patch)
2016-08-20 11:07 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(48.76 KB, patch)
2016-08-20 11:22 PDT
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2016-08-20 11:07:45 PDT
Created
attachment 286542
[details]
Patch
WebKit Commit Bot
Comment 2
2016-08-20 11:09:36 PDT
Attachment 286542
[details]
did not pass style-queue: ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:64: Wrong number of spaces before statement. (expected: 41) [whitespace/indent] [4] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2016-08-20 11:22:41 PDT
Created
attachment 286543
[details]
Patch
WebKit Commit Bot
Comment 4
2016-08-20 11:24:34 PDT
Attachment 286543
[details]
did not pass style-queue: ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:64: Code inside a namespace should not be indented. [whitespace/indent] [4] ERROR: Source/WebCore/dom/MouseRelatedEvent.cpp:64: Wrong number of spaces before statement. (expected: 41) [whitespace/indent] [4] Total errors found: 2 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 5
2016-08-20 14:42:10 PDT
Committed
r204681
: <
http://trac.webkit.org/changeset/204681
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug