Bug 161023 - URLParser should parse IPv4 addresses
Summary: URLParser should parse IPv4 addresses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-19 18:21 PDT by Alex Christensen
Modified: 2016-08-22 10:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.76 KB, patch)
2016-08-19 18:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-08-19 18:21:46 PDT 
URLParser should parse IPv4 addresses
Comment 1 Alex Christensen 2016-08-19 18:25:08 PDT 
Created attachment 286510 [details]
Patch
Comment 2 Alex Christensen 2016-08-19 22:31:26 PDT 
Comment on attachment 286510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286510&action=review

efl build failure unrelated.

> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:122
> +TEST_F(URLParserTest, ParserDifferences)

These changes are because of the new URLParser being more standards compliant.
Comment 3 Darin Adler 2016-08-20 18:37:00 PDT 
Comment on attachment 286510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286510&action=review

>> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:122
>> +TEST_F(URLParserTest, ParserDifferences)
> 
> These changes are because of the new URLParser being more standards compliant.

Why is this comment in the patch review rather than in the test?
Comment 4 Alex Christensen 2016-08-21 22:21:59 PDT 
Comment on attachment 286510 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286510&action=review

>>> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:122
>>> +TEST_F(URLParserTest, ParserDifferences)
>> 
>> These changes are because of the new URLParser being more standards compliant.
> 
> Why is this comment in the patch review rather than in the test?

I'll put a comment in the next patch. I don't have SVN on my phone :(
There will be more differences and I'll put them here until we remove the old parser, then convert the tests to a new form because there will be no old parser to compare it with.
Comment 5 WebKit Commit Bot 2016-08-21 22:43:53 PDT 
Comment on attachment 286510 [details]
Patch

Clearing flags on attachment: 286510

Committed r204701: <http://trac.webkit.org/changeset/204701>
Comment 6 WebKit Commit Bot 2016-08-21 22:43:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 youenn fablet 2016-08-22 05:54:06 PDT 
Is the URL parser ready enough to start using within fetch API?
Comment 8 Alex Christensen 2016-08-22 10:01:16 PDT 
(In reply to comment #7)
> Is the URL parser ready enough to start using within fetch API?
Not yet