Bug 161016 – Merge MessageEncoder and ArgumentEncoder into Encoder

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Merge MessageEncoder and ArgumentEncoder into Encoder

[Anders Carlsson]

Created attachment 286490 [details]
Patch

[Tim Horton]

Comment on attachment 286490 [details]
Patch

rs=me

[Darin Adler]

Comment on attachment 286490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286490&action=review

Change log isn’t so great.

Diff doesn’t show the changes to Encoder.h/cpp, annoying since our Subversion patch shows those even when combined with a rename.

More of the touched header files should get the #pragma once treatment.

> Source/WebKit2/Platform/IPC/MessageReceiver.h:35
> -class MessageDecoder;
> -class MessageEncoder;
> +class Encoder;
>  class Connection;
> +class MessageDecoder;

Strange to re-sort this, but put Encoder before Connection!

> Source/WebKit2/Scripts/webkit/messages.py:122
> +            result.append('        DelayedReply(PassRefPtr<IPC::Connection>, std::unique_ptr<IPC::Encoder>);\n')

Irritating that this is still using PassRefPtr.

[Anders Carlsson]

(In reply to comment #3)
> Comment on attachment 286490 [details]
> Patch
> 

> More of the touched header files should get the #pragma once treatment.
> 

Was planning on fix all those in one patch sometime in the future.

> > Source/WebKit2/Platform/IPC/MessageReceiver.h:35
> > -class MessageDecoder;
> > -class MessageEncoder;
> > +class Encoder;
> >  class Connection;
> > +class MessageDecoder;
> 
> Strange to re-sort this, but put Encoder before Connection!
> 
> > Source/WebKit2/Scripts/webkit/messages.py:122
> > +            result.append('        DelayedReply(PassRefPtr<IPC::Connection>, std::unique_ptr<IPC::Encoder>);\n')
> 
> Irritating that this is still using PassRefPtr.

Yes.

[Anders Carlsson]

Committed r204665: <http://trac.webkit.org/changeset/204665>