Bug 161009 – Clean up FontPlatformData::hash()

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Myles C. Maxfield]

Clean up FontPlatformData::hash()

[Myles C. Maxfield]

Created attachment 286470 [details]
Patch

[Myles C. Maxfield]

Created attachment 286520 [details]
Patch

[Myles C. Maxfield]

Created attachment 286521 [details]
Patch

[Build Bot]

Comment on attachment 286521 [details]
Patch

Attachment 286521 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1903880

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 286523 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 286521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286521&action=review

> Source/WebCore/platform/graphics/cocoa/FontPlatformDataCocoa.mm:61
> +unsigned FontPlatformData::hash() const
> +{
> +    uintptr_t flags = static_cast<uintptr_t>(m_isHashTableDeletedValue << 5 | m_textRenderingMode << 3 | m_orientation << 2 | m_syntheticBold << 1 | m_syntheticOblique);
> +    uintptr_t fontHash = reinterpret_cast<uintptr_t>(m_font.get());
> +    uintptr_t hashCodes[3] = { fontHash, m_widthVariant, flags };
> +    return StringHasher::hashMemory<sizeof(hashCodes)>(hashCodes);
> +}

This doesn’t look right. The hash function should hash the same things that the is-equal function compares. Yet this is hashing things that platformIsEqual does not even look at. Can that really be correct?

[Myles C. Maxfield]

*** This bug has been marked as a duplicate of bug 167061 ***